SAA-459: Remove use of Jquery code, and upgrade peer dependency of Jquery from moj-frontend #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
smcveigh941
commented
Mar 12, 2023
•
smcveigh941
commented
- Remove jQuery-UI
- Remove jQuery code. jQuery still required as peer dependency of moj-frontend
- Bumped dependency versions
smcveigh941
commented
Mar 12, 2023
| var valueA = this.getCellValue(tdA) | ||
| var valueB = this.getCellValue(tdB) | ||
| var valueA = this.getCellValue($(tdA)) | ||
| var valueB = this.getCellValue($(tdB)) |
There was a problem hiding this comment.
The function from moj-library requires this parameter to be a Jquery object. sigh
smcveigh941
commented
Mar 12, 2023
| @@ -113,16 +113,15 @@ | |||
| "govuk-frontend": "^4.5.0", | |||
| "helmet": "^6.0.0", | |||
| "http-errors": "^2.0.0", | |||
| "jquery": "^3.6.3", | |||
| "jquery-ui-dist": "^1.13.2", | |||
| "jquery": "^3.6.4", | |||
There was a problem hiding this comment.
jQuery library to be removed in the future. However is still required for now since the MoJ library components require it. Considering raising with frontend team about removing the need for jQuery, though it would require a major version change of that library.
Bumping the version for now to suppress vulnerabilities.
Note issue: ministryofjustice/moj-frontend#134
smcveigh941
force-pushed
the
dev/SAA-459-remove-jquery
branch
from
77a4bd1
to
cbcb98c
Compare
…uery from moj-frontend
smcveigh941
force-pushed
the
dev/SAA-459-remove-jquery
branch
from
cbcb98c
to
3d87eaa
Compare
| @@ -4,17 +4,17 @@ ActivitiesFrontend.ListFilter = function (container) { | |||
| new MOJFrontend.FilterToggleButton({ | |||
| startHidden: true, | |||
| toggleButton: { | |||
| container: $('.moj-action-bar__filter'), | |||
| container: document.getElementsByClassName('.moj-action-bar__filter'), | |||
There was a problem hiding this comment.
Need to remove the dot at the start of the class name, or you could use query selector,
document.querySelectorAll('.moj-action-bar__filter')
leejacobson-moj
approved these changes
Mar 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.