Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Map 1410 remove options #3206

Merged
merged 10 commits into from
Aug 5, 2024
Merged

Map 1410 remove options #3206

merged 10 commits into from
Aug 5, 2024

Conversation

danbenton-mojdt
Copy link
Contributor

@danbenton-mojdt danbenton-mojdt commented Jul 31, 2024

Proposed changes

What changed

Remove from location from list of available destinations when booking or editing a move.
Remove from and to locations from list of available destinations when adding or editing a lodge
When booking an allocation, current location isn't removed from either location field

Why did it change

To prevent users trying to book moves from/to the same location and ending up on an error screen

Issue tracking

Screenshots

image image

Checklists

Testing

Automated testing

  • Added unit tests to cover changes
  • Added end-to-end tests to cover any journey changes

Manual testing

Has been tested in the following browsers:

  • Chrome
  • Firefox
  • Edge
  • Internet Explorer

Environment variables

  • No environment variables were added or changed

Other considerations

Commit messages with a fix or feat type are automatically used to generate the changelog and
GitHub release notes during the release task. Please make sure they will read well on their own in a
summary of changes and that the commit body gives a more detailed description of those changes if necessary.

@danbenton-mojdt danbenton-mojdt temporarily deployed to booksecuremove-pr-3206 July 31, 2024 15:12 Destroyed
@danbenton-mojdt danbenton-mojdt temporarily deployed to booksecuremove-pr-3206 July 31, 2024 16:12 Destroyed
@danbenton-mojdt danbenton-mojdt temporarily deployed to booksecuremove-pr-3206 August 1, 2024 08:28 Destroyed
@danbenton-mojdt danbenton-mojdt temporarily deployed to booksecuremove-pr-3206 August 1, 2024 09:15 Destroyed
@danbenton-mojdt danbenton-mojdt temporarily deployed to booksecuremove-pr-3206 August 1, 2024 09:37 Destroyed
@danbenton-mojdt danbenton-mojdt temporarily deployed to booksecuremove-pr-3206 August 2, 2024 12:47 Destroyed
@danbenton-mojdt danbenton-mojdt temporarily deployed to booksecuremove-pr-3206 August 2, 2024 14:48 Destroyed
@danbenton-mojdt danbenton-mojdt marked this pull request as ready for review August 2, 2024 14:50
@danbenton-mojdt danbenton-mojdt requested a review from a team as a code owner August 2, 2024 14:50
@danbenton-mojdt danbenton-mojdt merged commit b4e4ef8 into main Aug 5, 2024
10 checks passed
@danbenton-mojdt danbenton-mojdt deleted the MAP-1410-remove-options branch August 5, 2024 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants