Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[P4 1440] Provide ability to update to location frontend #493

Merged

Conversation

solidgoldpig
Copy link
Contributor

@solidgoldpig solidgoldpig commented May 6, 2020

Adds ability to change where a move is going to or, if a prison recall, amend the move’s additional information.

Adds link to edit move details from move view page.

Move_details_for_MELLIE__ROGER

Prison recall move
Where_is_this_person_moving__-_update_move

Other move types
Where_is_this_person_moving__-_update_move

Checklist

@teneightfive teneightfive temporarily deployed to booksecuremove-pr-493 May 6, 2020 18:25 Inactive
@solidgoldpig solidgoldpig force-pushed the P4-1440-provide-ability-to-update-to-location-frontend branch from 1cd8143 to 08d45d4 Compare May 6, 2020 18:36
@teneightfive teneightfive temporarily deployed to booksecuremove-pr-493 May 6, 2020 18:36 Inactive
@solidgoldpig solidgoldpig changed the title P4 1440 provide ability to update to location frontend Provide ability to update to location frontend [P4 1440] May 6, 2020
@solidgoldpig solidgoldpig force-pushed the P4-1440-provide-ability-to-update-to-location-frontend branch from 08d45d4 to 50d9033 Compare May 6, 2020 21:30
@teneightfive teneightfive temporarily deployed to booksecuremove-pr-493 May 6, 2020 21:30 Inactive
@solidgoldpig solidgoldpig force-pushed the P4-1440-provide-ability-to-update-to-location-frontend branch from 50d9033 to 297bae6 Compare May 6, 2020 22:04
@teneightfive teneightfive temporarily deployed to booksecuremove-pr-493 May 6, 2020 22:05 Inactive
@solidgoldpig solidgoldpig marked this pull request as ready for review May 6, 2020 22:23
Copy link
Contributor

@teneightfive teneightfive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Only a couple of minor comments

common/lib/api-client/models.test.js Outdated Show resolved Hide resolved
common/services/move.test.js Outdated Show resolved Hide resolved
app/move/controllers/update/move-details.js Outdated Show resolved Hide resolved
locales/en/moves.json Show resolved Hide resolved
@solidgoldpig solidgoldpig force-pushed the P4-1440-provide-ability-to-update-to-location-frontend branch from 297bae6 to 280d861 Compare May 7, 2020 09:23
@teneightfive teneightfive temporarily deployed to booksecuremove-pr-493 May 7, 2020 09:24 Inactive
@solidgoldpig solidgoldpig changed the title Provide ability to update to location frontend [P4 1440] [P4 1440] Provide ability to update to location frontend May 7, 2020
@solidgoldpig solidgoldpig force-pushed the P4-1440-provide-ability-to-update-to-location-frontend branch from 280d861 to 45a46ef Compare May 7, 2020 10:57
@teneightfive teneightfive temporarily deployed to booksecuremove-pr-493 May 7, 2020 10:57 Inactive
@codeclimate
Copy link

codeclimate bot commented May 7, 2020

Code Climate has analyzed commit efdfe82 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (90% is the threshold).

This pull request will bring the total coverage in the repository to 99.4% (0.0% change).

View more on Code Climate.

@solidgoldpig solidgoldpig force-pushed the P4-1440-provide-ability-to-update-to-location-frontend branch from efdfe82 to 5ce10d5 Compare May 7, 2020 14:44
@teneightfive teneightfive temporarily deployed to booksecuremove-pr-493 May 7, 2020 14:45 Inactive
@solidgoldpig solidgoldpig merged commit f04ac91 into master May 7, 2020
@solidgoldpig solidgoldpig deleted the P4-1440-provide-ability-to-update-to-location-frontend branch May 7, 2020 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants