Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

P4 1349 remove person from allocation #549

Merged
merged 13 commits into from
May 28, 2020
Merged

P4 1349 remove person from allocation #549

merged 13 commits into from
May 28, 2020

Conversation

solidgoldpig
Copy link
Contributor

Adds unassign route to move

Remove_person_from_allocation_-_Cancel_allocation

Adds unassign link to allocation view and suppresses status badge

Before After
View_allocation View_allocation

Checklist

@solidgoldpig solidgoldpig mentioned this pull request May 28, 2020
Closed
2 tasks
@teneightfive teneightfive temporarily deployed to booksecuremove-pr-549 May 28, 2020 08:58 Inactive
@solidgoldpig solidgoldpig force-pushed the P4-1349-remove-person-from-allocation branch from fe2165e to c0c5294 Compare May 28, 2020 09:06
@teneightfive teneightfive temporarily deployed to booksecuremove-pr-549 May 28, 2020 09:06 Inactive
@solidgoldpig solidgoldpig force-pushed the P4-1349-remove-person-from-allocation branch from c0c5294 to 84dd00b Compare May 28, 2020 09:18
@teneightfive teneightfive temporarily deployed to booksecuremove-pr-549 May 28, 2020 09:19 Inactive
teneightfive
teneightfive suggested changes May 28, 2020
View reviewed changes
app/move/controllers/unassign.js Outdated Show resolved Hide resolved
app/move/controllers/unassign.js Outdated Show resolved Hide resolved
app/move/controllers/unassign.js Outdated Show resolved Hide resolved
app/move/controllers/unassign.js Outdated Show resolved Hide resolved
app/move/controllers/unassign.js Outdated Show resolved Hide resolved
app/move/views/unassign.njk Show resolved Hide resolved
app/allocation/views/view.njk Outdated Show resolved Hide resolved
app/allocation/views/view.njk Outdated Show resolved Hide resolved
app/allocation/controllers/view.js Outdated Show resolved Hide resolved
locales/en/allocations.json Show resolved Hide resolved
@teneightfive teneightfive temporarily deployed to booksecuremove-pr-549 May 28, 2020 14:00 Inactive
@teneightfive teneightfive temporarily deployed to booksecuremove-pr-549 May 28, 2020 15:10 Inactive
@solidgoldpig solidgoldpig force-pushed the P4-1349-remove-person-from-allocation branch from 3c21bbd to 4d4358d Compare May 28, 2020 15:15
@teneightfive teneightfive temporarily deployed to booksecuremove-pr-549 May 28, 2020 15:15 Inactive
teneightfive
teneightfive reviewed May 28, 2020
View reviewed changes
Copy link
Contributor

@teneightfive teneightfive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Be good to remove the API calls that we don't need and tidy up async/await use. Apart from that its good to go.

app/move/controllers/unassign.js Outdated Show resolved Hide resolved
common/services/move.test.js Show resolved Hide resolved
app/move/views/unassign.njk Outdated Show resolved Hide resolved
app/move/controllers/unassign.js Outdated Show resolved Hide resolved
@teneightfive teneightfive temporarily deployed to booksecuremove-pr-549 May 28, 2020 15:44 Inactive
@teneightfive teneightfive temporarily deployed to booksecuremove-pr-549 May 28, 2020 15:49 Inactive
@teneightfive teneightfive temporarily deployed to booksecuremove-pr-549 May 28, 2020 15:54 Inactive
@solidgoldpig solidgoldpig force-pushed the P4-1349-remove-person-from-allocation branch from 42fc321 to e7b96e3 Compare May 28, 2020 15:58
@teneightfive teneightfive temporarily deployed to booksecuremove-pr-549 May 28, 2020 15:58 Inactive
@codeclimate
Copy link

codeclimate bot commented May 28, 2020

Code Climate has analyzed commit e7b96e3 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (90% is the threshold).

This pull request will bring the total coverage in the repository to 99.5% (0.0% change).

View more on Code Climate.

@solidgoldpig solidgoldpig merged commit fce84e6 into master May 28, 2020
@solidgoldpig solidgoldpig deleted the P4-1349-remove-person-from-allocation branch May 28, 2020 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teneightfive teneightfive teneightfive approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@solidgoldpig @teneightfive