[P4-1784] Render flags from the Person Escort Record instead of the move request #686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teneightfive
force-pushed
the
person-escort-record/render-flags
branch
from
713960f
to
a428ccd
Compare
teneightfive
force-pushed
the
person-escort-record/render-flags
branch
from
a428ccd
to
688aa7c
Compare
teneightfive
force-pushed
the
person-escort-record/render-flags
branch
from
688aa7c
to
05e8ed2
Compare
teneightfive
force-pushed
the
person-escort-record/render-flags
branch
from
05e8ed2
to
e6137e5
Compare
teneightfive
force-pushed
the
person-escort-record/render-flags
branch
from
e6137e5
to
50796cb
Compare
teneightfive
force-pushed
the
person-escort-record/render-flags
branch
from
50796cb
to
d5bb002
Compare
teneightfive
force-pushed
the
person-escort-record/render-flags
branch
from
d5bb002
to
32646ae
Compare
teneightfive
force-pushed
the
person-escort-record/render-flags
branch
from
32646ae
to
d3b424d
Compare
teneightfive
requested review from
danielepolencic,
solidgoldpig,
Andy-Millar and
JadeNConroy
teneightfive
force-pushed
the
person-escort-record/render-flags
branch
from
d3b424d
to
499f657
Compare
danielepolencic
approved these changes
Jul 28, 2020
teneightfive
added
blocked
This adds support to receive flags as part of the Person Escort Record models and relationships.
This extends the card component to support the inclusion of the GOV.UK Inset Text component. This pattern will be used to display a message if the item in the card is in particular states, for example, with an incomplete Person Escort Record.
This creates a new presenter that will be used within the card component and on the move detail view to render the flags for a move from the Person Escort Record framework.
This introduces the ability to display a tag list from the Person Escort Record framework if this feature is enabled. It will replace the existing method of displaying the tags from the assessment answers, but for now both need to live side by side until the feature is completely released.
This updates the profile to card component to display tags based on the Person Escort Record instead of the previous assessment answers. Because the feature is being developed in the background to avoid any breaking changes this change needs to support the existing method unless a feature flag is enabled.
Running the tests in a different timezone highlighted an area in the unit tests where we weren't mocking the timezone. This fixes that by using timezone mock to ensure the tests will still pass.
teneightfive
force-pushed
the
person-escort-record/render-flags
branch
from
499f657
to
76062f7
Compare
|
Code Climate has analyzed commit 76062f7 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (90% is the threshold). This pull request will bring the total coverage in the repository to 99.5% (0.0% change). View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
What changed
This set of changes amend the behaviour for display tags for a move. Tags will now only be shown when
all sections of the Person Escort Record are completed.
If they have not been completed or a PER has not yet been started it will display a message in place of the
tags showing what needs to be done.
Why did it change
The Person Escort Record is a new feature that allows risk and health information to be collected in more
detail. With this new addition the previous behaviour for rendering flags no longer fits or is appropriate.
This new behaviour avoids the need for any complicated logic to combine the tags and instead will only
display if we know all the information we need.
Issue tracking
Screenshots
Dashboard
This shows the two variations for a complete PER and an incomplete PER
Move detail (incomplete Person Escort Record)
This version display when no Person Escort Record has been started or any section is not complete.
Move detail (complete Person Escort Record)
This version displays when all sections of the Person Escort Record have been completed.
Checklists
Testing
Automated testing
Manual testing
Has been tested in the following browsers:
Environment variables
Other considerations
Commit messages with a
fixorfeattype are automatically used to generate the changelog andGitHub release notes during the release task. Please make sure they will read well on their own in a
summary of changes and that the commit body gives a more detailed description of those changes if necessary.