Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enrich Sentry information #795

Merged
merged 2 commits into from
Sep 20, 2020
Merged

Enrich Sentry information #795

merged 2 commits into from
Sep 20, 2020

Conversation

teneightfive
Copy link
Contributor

@teneightfive teneightfive commented Sep 20, 2020

Proposed changes

What changed

This change enriches the information provided to Sentry when issues
occur.

It includes the addition of the request ID so that it can be traced
through other services.

It also includes some location and user information to help see how
frequently errors occur for particular users or locations.

Why did it change

Providing this extra information will make debugging easier.

Checklists

Testing

Automated testing

  • Added unit tests to cover changes
  • Added end-to-end tests to cover any journey changes

Manual testing

Has been tested in the following browsers:

  • Chrome
  • Firefox
  • Edge
  • Internet Explorer

Environment variables

  • No environment variables were added or changed

Other considerations

Commit messages with a fix or feat type are automatically used to generate the changelog and
GitHub release notes during the release task. Please make sure they will read well on their own in a
summary of changes and that the commit body gives a more detailed description of those changes if necessary.

@teneightfive teneightfive temporarily deployed to booksecuremove-pr-795 September 20, 2020 18:00 Inactive
This follows the official documentation more closely and removes
some of the unnecessary packages previously being used to notify
Sentry:
https://docs.sentry.io/product/releases/release-automation/circleci/
This change enriches the information provided to Sentry when issues
occur.

It includes the addition of the request ID so that it can be traced
through other services.

It also includes some location and user information to help see how
frequently errors occur for particular users or locations.
@teneightfive teneightfive temporarily deployed to booksecuremove-pr-795 September 20, 2020 18:05 Inactive
@codeclimate
Copy link

codeclimate bot commented Sep 20, 2020

Code Climate has analyzed commit 6a4d2b0 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (90% is the threshold).

This pull request will bring the total coverage in the repository to 97.0% (0.0% change).

View more on Code Climate.

@teneightfive teneightfive merged commit acfa5de into master Sep 20, 2020
@teneightfive teneightfive deleted the sentry-releases branch September 20, 2020 18:18
@teneightfive teneightfive linked an issue Sep 22, 2020 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve performance metrics and error monitoring
1 participant