feat(move): Grant OCA user ability to move from prison to SCH and STC #824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code Climate has analyzed commit c7a0a92 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (90% is the threshold). This pull request will bring the total coverage in the repository to 97.3% (0.0% change). View more on Code Climate. |
merlinc
reviewed
Sep 29, 2020
| @@ -87,6 +87,8 @@ const ocaPermissions = [ | |||
| 'move:view', | |||
| 'move:create', | |||
| 'move:create:prison_transfer', | |||
| 'move:create:secure_childrens_home', | |||
There was a problem hiding this comment.
Can we get some E2E tests for these additions, so that we're protected in the future if requirements change?
There was a problem hiding this comment.
Added issue #827
JadeNConroy
approved these changes
Sep 29, 2020
teneightfive
approved these changes
Sep 30, 2020
solidgoldpig
deleted the
P4-2254-grant-oca-user-ability-to-move-to-sch-and-stc
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements P4-2254
Proposed changes
What changed
Grants ability to OCA user to create moves from prison to SCH and STC
Why did it change
So that OCA users can request youth moves
Issue tracking
Screenshots
Checklists
Testing
Automated testing
Manual testing
Has been tested in the following browsers:
Environment variables
Other considerations