Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify sp report queries to ignore appointments without feedback #1997

Merged
merged 2 commits into from
Aug 14, 2024

Conversation

awhodgson256
Copy link
Contributor

What does this pull request do?

Filters SAA and delivery session first appointment records where the record has no feedback from the report

What is the intent behind these changes?

Prevent rescheduled appointments without feedback showing in the report

@awhodgson256 awhodgson256 requested a review from a team as a code owner August 9, 2024 14:01
@awhodgson256 awhodgson256 marked this pull request as draft August 9, 2024 14:01
@awhodgson256 awhodgson256 force-pushed the IPB-1234/filter-without-feedback-sp-report branch from 2a05d93 to 67f2f9e Compare August 12, 2024 09:55
@awhodgson256 awhodgson256 marked this pull request as ready for review August 12, 2024 09:57
kth13
kth13 previously approved these changes Aug 13, 2024
Copy link
Contributor

@kth13 kth13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@awhodgson256 awhodgson256 force-pushed the IPB-1234/filter-without-feedback-sp-report branch from 67f2f9e to 716138a Compare August 14, 2024 08:07
Copy link
Contributor

@kth13 kth13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@awhodgson256 awhodgson256 merged commit 239e806 into main Aug 14, 2024
7 checks passed
@awhodgson256 awhodgson256 deleted the IPB-1234/filter-without-feedback-sp-report branch August 14, 2024 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants