Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAP-1457 41 PrisonerSearchService DataClass Alert covered #214

Conversation

marcusaleman
Copy link
Contributor

@marcusaleman marcusaleman commented Aug 7, 2024

MAP-1457 41 PrisonerSearchService DataClass Alert covered
PrisonerSearchService 66%

I have added test coverage to this Data Class
data class Alert(
@Schema(description = "Alert type", example = "X", required = true)
val alertType: String,
@Schema(description = "Alert code", example = "XA", required = true)
val alertCode: String,
@Schema(description = "Active alert", example = "true", required = true)
val active: Boolean,
@Schema(description = "Expired", example = "false", required = true)
val expired: Boolean,
)

Copy link
Contributor

@Mjwillis Mjwillis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Label the varibles

Copy link
Contributor

@Mjwillis Mjwillis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Mjwillis Mjwillis merged commit 4ae8f84 into main Aug 12, 2024
2 checks passed
@Mjwillis Mjwillis deleted the MAP-1457-41-Check-gaps-in-test-coverage-for-Kotlin-project-location-api-PrisonIdTest branch August 12, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants