Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HAAR-1891: Add newly-included Manage Users api to health checks #255

Merged
merged 2 commits into from
Nov 7, 2023

Conversation

ushkarev
Copy link
Contributor

@ushkarev ushkarev commented Nov 6, 2023

I think this was missed off from #247 when moving a couple of calls from HMPPS Auth to HMPPS Manage Users

@ushkarev ushkarev marked this pull request as ready for review November 6, 2023 17:46
Comment on lines +40 to +54
const ping = () =>
stubFor({
request: {
method: 'GET',
urlPattern: '/manage-users-api/health/ping',
},
response: {
status: 200,
},
})

export default {
stubManageUser: (name = 'john smith'): Promise<[Response, Response]> =>
Promise.all([stubUser(name), stubUserRoles()]),
stubManageUsersPing: ping,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the stubbing code is copied almost verbatim from auth

Copy link
Contributor

@andrewrlee andrewrlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewrlee andrewrlee merged commit db84e2b into main Nov 7, 2023
4 checks passed
@andrewrlee andrewrlee deleted the manage-users-health-check branch November 7, 2023 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants