Use in-memory token store when developing locally #273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes the need for a local Redis container
andrewrlee
reviewed
Nov 28, 2023
server/data/index.ts
Outdated
|
|
||
| type RestClientBuilder<T> = (token: string) => T | ||
|
|
||
| export const dataAccess = () => ({ | ||
| applicationInfo, | ||
| hmppsAuthClient: new HmppsAuthClient(new TokenStore(createRedisClient())), | ||
| hmppsAuthClient: new HmppsAuthClient( | ||
| config.redis.enabled ? new RedisTokenStore(createRedisClient()) : new TestingTokenStore(), |
There was a problem hiding this comment.
Worth calling this InMemoryToken store?
We use an in memory token store for jobs as it means don't need to worry about redis being accessible (dodgy DNS issues)
There was a problem hiding this comment.
Good call, I'll rename it
andrewrlee
reviewed
Nov 28, 2023
| import RedisStore from 'connect-redis' | ||
| import express, { Router } from 'express' | ||
| import { createRedisClient } from '../data/redisClient' | ||
| import config from '../config' | ||
| import logger from '../../logger' | ||
|
|
||
| export default function setUpWebSession(): Router { | ||
| const client = createRedisClient() | ||
| client.connect().catch((err: Error) => logger.error(`Error connecting to Redis`, err)) | ||
| let store: Store |
There was a problem hiding this comment.
should this fall back to the inmemory store? what happens if you pass undefined?
There was a problem hiding this comment.
Express defaults to a MemoryStore, so passing undefined means it uses its own in-memory store for session data.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the need for a local Redis container