Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to GovUK 5 and MoJ 2.0 #297

Merged
merged 2 commits into from
Jan 9, 2024
Merged

Conversation

psoleckimoj
Copy link
Contributor

No description provided.

Copy link

@tpmcgowan tpmcgowan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@andrewrlee andrewrlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@psoleckimoj psoleckimoj merged commit a3ae834 into main Jan 9, 2024
4 checks passed
@psoleckimoj psoleckimoj deleted the feature/update-to-govuk-5-mojds-2 branch January 9, 2024 13:09
dhirajshettymoj added a commit to ministryofjustice/hmpps-send-legal-mail-staff-ui that referenced this pull request Jan 15, 2024
dhirajshettymoj added a commit to ministryofjustice/hmpps-send-legal-mail-staff-ui that referenced this pull request Jan 15, 2024
yndajas added a commit to ministryofjustice/hmpps-accredited-programmes-ui that referenced this pull request Jan 30, 2024
To 5.0.0 and 2.1.0 respectively. The latter is an important upgrade for
WCAG 2.2 accessibility compliance

The visually-hidden text in summary list actions now automatically
includes the title in brackets, so there's a minor change there

This is similar to other PRs listed below, with one small exception: the
path to components in `nunjucksSetup` is fixed

Similar PRs:
- ministryofjustice/hmpps-approved-premises-ui#1281
- ministryofjustice/hmpps-template-typescript#297

GOV.UK Frontend migration guidance: https://github.com/alphagov/govuk-frontend/releases/tag/v5.0.0#:~:text=Google%20account).-,Breaking%20changes,-You%20must%20make
yndajas added a commit to ministryofjustice/hmpps-accredited-programmes-ui that referenced this pull request Jan 31, 2024
To 5.0.0 and 2.1.0 respectively. The latter is an important upgrade for
WCAG 2.2 accessibility compliance

The visually-hidden text in summary list actions now automatically
includes the title in brackets, so there's a minor change there

This is similar to other PRs listed below, with one small exception: the
path to components in `nunjucksSetup` is fixed

Similar PRs:
- ministryofjustice/hmpps-approved-premises-ui#1281
- ministryofjustice/hmpps-template-typescript#297

GOV.UK Frontend migration guidance: https://github.com/alphagov/govuk-frontend/releases/tag/v5.0.0#:~:text=Google%20account).-,Breaking%20changes,-You%20must%20make
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants