Update MoJ frontend, dropping jQuery which is no longer required #303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rrently included
…ckage.json because we’d usually want to stick to an LTS version rather than move to the latest
| ).forEach(dir => { | ||
| router.use('/assets', express.static(path.join(process.cwd(), dir), cacheControl)) | ||
| }) | ||
|
|
||
| Array.of('/node_modules/govuk_frontend_toolkit/images').forEach(dir => { | ||
| router.use('/assets/images/icons', express.static(path.join(process.cwd(), dir), cacheControl)) |
There was a problem hiding this comment.
did you mean to remove this too?
There was a problem hiding this comment.
yup i explained in that commit that we don't even install the deprecated govuk_frontend_toolkit package
|
Seems the sortable table component still needs jQuery by the way |
Odd! There's a still-open issue from 2021 about this: ministryofjustice/moj-frontend#134. jQuery is definitely still being used on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Might be worth noting that cypress still bundles jquery so it will remain available for integration tests