Using the user token to get user details #352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brightonsbox
force-pushed
the
jb/hmppsUser
branch
5 times, most recently
from
4c2f727
to
0656ec0
Compare
|
If you've managed to pull out managed-users-api entirely I think you can pull out some values from the helm files too |
brightonsbox
force-pushed
the
jb/hmppsUser
branch
2 times, most recently
from
3fd572d
to
c54c5a9
Compare
andrewrlee
reviewed
May 13, 2024
| } | ||
|
|
||
| if (res.locals.user.authSource === 'nomis') { | ||
| res.locals.user.staffId = +userId || undefined |
There was a problem hiding this comment.
any reason not to use parseInt here?
(just as exemplar code, this handles a few values weirdly and wouldn't encourage people to use coercion generally)
brightonsbox
dismissed stale reviews from petergphillips and andrewrlee
via
67db0f8
brightonsbox
force-pushed
the
jb/hmppsUser
branch
from
c54c5a9
to
67db0f8
Compare
tpmcgowan
added a commit
to ministryofjustice/book-a-prison-visit-staff-ui
that referenced
this pull request
Oct 17, 2024
Incorporate changes from ministryofjustice/hmpps-template-typescript#352
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.