-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using the user token to get user details #352
Conversation
4c2f727
to
0656ec0
Compare
If you've managed to pull out managed-users-api entirely I think you can pull out some values from the helm files too |
3fd572d
to
c54c5a9
Compare
} | ||
|
||
if (res.locals.user.authSource === 'nomis') { | ||
res.locals.user.staffId = +userId || undefined |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any reason not to use parseInt here?
(just as exemplar code, this handles a few values weirdly and wouldn't encourage people to use coercion generally)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
67db0f8
c54c5a9
to
67db0f8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Incorporate changes from ministryofjustice/hmpps-template-typescript#352
No description provided.