Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EL-1894: MTR Accelerated - Tidy Up #1668

Merged
merged 8 commits into from
Nov 26, 2024
Merged

EL-1894: MTR Accelerated - Tidy Up #1668

merged 8 commits into from
Nov 26, 2024

Conversation

MazOneTwoOne
Copy link
Contributor

@MazOneTwoOne MazOneTwoOne commented Nov 20, 2024

Jira ticket

What changed and why

  • update content on "non-passporting benefits"
  • update content on "add another benefit" page
  • tidy-up en.yml & remove redundant partials

Guidance to review

  • n/a

Checklist

Before you ask people to review this PR:

  • Tests and rubocop should be passing
  • Branch is generally up to date with main Github - definitely no conflicts
  • No unnecessary whitespace changes. These make diffs harder to read and conflicts more likely.
  • PR description says what changed and why, with a link to the JIRA story.
  • Diff has been checked for unexpected changes being included.
  • Commit messages say why the change was made.

- update hint `non-passporting` hint text
@MazOneTwoOne MazOneTwoOne changed the base branch from el-1893-mtr-broken-tests-feature-flag to main November 20, 2024 16:55
@MazOneTwoOne MazOneTwoOne marked this pull request as ready for review November 25, 2024 11:23
@MazOneTwoOne MazOneTwoOne requested a review from a team as a code owner November 25, 2024 11:23
@MazOneTwoOne MazOneTwoOne added the UAT Keep PR open to keep ephemeral UAT URL alive label Nov 26, 2024
@MazOneTwoOne MazOneTwoOne merged commit bcd945a into main Nov 26, 2024
12 checks passed
@MazOneTwoOne MazOneTwoOne deleted the el-1894-mtr-tidy-up branch November 26, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved UAT Keep PR open to keep ephemeral UAT URL alive
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants