Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump Rails to 6.1.0 #426

Merged
merged 4 commits into from
Jan 21, 2021
Merged

Bump Rails to 6.1.0 #426

merged 4 commits into from
Jan 21, 2021

Conversation

kmahern
Copy link
Contributor

@kmahern kmahern commented Jan 19, 2021 •
edited
Loading

What

Bump Rails to 6.1.0

Ticket

N/A

Why

Application framework dependency update

How

  1. (Temporarily) Remove meta_request gem. This was causing multiple failures:
Failure/Error: visit '/'
     
     SystemStackError:
       stack level too deep

SystemStackError:
        stack level too deep
      # /home/circleci/vendor/bundle/ruby/2.7.0/gems/activesupport-6.1.0/lib/active_support/core_ext/object/json.rb:173:in `each'
      # /home/circleci/vendor/bundle/ruby/2.7.0/gems/activesupport-6.1.0/lib/active_support/core_ext/object/json.rb:173:in `as_json'
      # /home/circleci/vendor/bundle/ruby/2.7.0/gems/activesupport-6.1.0/lib/active_support/core_ext/object/json.rb:174:in `block in as_json'
...

This is documented here rails/rails#40781 and rails/rails#40698

  1. The specs were generating multiple can't modify frozen Array: [] errors. I believe this was due to a change in Active Model errors as documented here https://edgeguides.rubyonrails.org/6_1_release_notes.html and here https://code.lulalala.com/2020/0531-1013.html. The fix was to use add instead of append.

dependabot-preview bot and others added 4 commits January 19, 2021 15:18
@dependabot-preview @kmahern
Bump rails from 6.0.3.4 to 6.1.0
3fd8a03 
Bumps [rails](https://github.com/rails/rails) from 6.0.3.4 to 6.1.0.
- [Release notes](https://github.com/rails/rails/releases)
- [Commits](rails/rails@v6.0.3.4...v6.1.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
@jsugarman @kmahern
Replace deprecated config option
7a3c322 
Fixes

```
DEPRECATION WARNING: action_view.raise_on_missing_translations is deprecated and will be
removed in Rails 6.2. Set i18n.raise_on_missing_translations instead. Note that this new
setting also affects how missing translations are handled in controllers. (called from <top (required)>
at /home/circleci/repo/config/environment.rb:7)
```
@kmahern
Remove meta_request gem
ed06bad
@kmahern
Attempt to fix can't modify frozen Array: [] error
e73737e
@kmahern kmahern changed the title Rails 6.1.0 ka Bump Rails to 6.1.0 Jan 21, 2021
@kmahern kmahern marked this pull request as ready for review January 21, 2021 08:26
@jrmhaig
Copy link
Contributor

jrmhaig commented Jan 21, 2021

Also related to the stack level problem: dejan/rails_panel#178

jrmhaig
jrmhaig approved these changes Jan 21, 2021
View reviewed changes
Copy link
Contributor

@jrmhaig jrmhaig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good

@kmahern kmahern merged commit 6f8eb7a into master Jan 21, 2021
@kmahern kmahern deleted the rails-6.1.0-ka branch January 21, 2021 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrmhaig jrmhaig jrmhaig approved these changes

@jsugarman jsugarman Awaiting requested review from jsugarman

@naseberry naseberry Awaiting requested review from naseberry

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kmahern @jrmhaig @jsugarman