Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Colour contrast for Primary navigation hover is not AA compliant #447

Closed
gregtyler opened this issue Mar 10, 2023 · 3 comments
Closed

Colour contrast for Primary navigation hover is not AA compliant #447

gregtyler opened this issue Mar 10, 2023 · 3 comments
Labels
accessibility bug A task that fixes something that isn't working released

Comments

@gregtyler
Copy link
Contributor

Description

When hovering over a navigation item on the Primary navigation component, the link text is #5694ca on a background of #f3f2f1. At a colour contrast ratio of 2.89:1, this is not AA accessible.

image

Versions

Discovered in v1.6.4, but presumably has been a problem for much longer.

Additional Information

The GOV.UK Design System documentation (which I think the component was originally forked from) is now using a darker colour and additional underline on hover, which fixes the contrast issue and also ensures users who aren't able to detect the contrast difference can still see a hover effect.

image

@gregtyler gregtyler added bug A task that fixes something that isn't working accessibility labels Mar 10, 2023
@richpjames
Copy link

This is also an issue in Subnavigation

@euhyung
Copy link

euhyung commented Sep 11, 2023

Have been checking whether there's anything in the Design System we could refer to, found this: plans to tackle (pending WCAG 2.2 review), considering adding an accessibility comment on both the primary and subnavigation, (side navgiation not affected) on our side, for accessible use

gregtyler added a commit that referenced this issue Dec 15, 2023
…inks

Use the standard GDS link hover colour to ensure links colour contrast is sufficient for
readability.

Fixes #447
gregtyler added a commit that referenced this issue Dec 15, 2023
…inks

Use the standard GDS link hover colour to ensure links colour contrast is sufficient for
readability.

Fixes #447
gregtyler added a commit that referenced this issue Dec 15, 2023
Applies to Primary navigation, Sub navigation and Side navigation.

Use the standard GDS link hover colour to ensure links colour contrast is sufficient for
readability.

Ensure borders follow suit, and ensure they're always on the same side of the element.

Fixes #447
gregtyler added a commit that referenced this issue Dec 15, 2023
Applies to Primary navigation, Sub navigation and Side navigation.

Use the standard GDS link hover colour to ensure links colour contrast is sufficient for
readability.

Ensure borders follow suit, and ensure they're always on the same side of the element.

Fixes #447
gregtyler added a commit that referenced this issue Jan 25, 2024
Applies to Primary navigation, Sub navigation and Side navigation.

Use the standard GDS link hover colour to ensure links colour contrast is sufficient for
readability.

Ensure borders follow suit, and ensure they're always on the same side of the element.

Fixes #447
gregtyler added a commit that referenced this issue Jan 25, 2024
Applies to Primary navigation, Sub navigation and Side navigation.

Use the standard GDS link hover colour to ensure links colour contrast is sufficient for
readability.

Ensure borders follow suit, and ensure they're always on the same side of the element.

Fixes #447
gregtyler added a commit that referenced this issue Jan 25, 2024
Applies to Primary navigation, Sub navigation and Side navigation.

Use the standard GDS link hover colour to ensure links colour contrast is sufficient for
readability.

Ensure borders follow suit, and ensure they're always on the same side of the element.

Fixes #447
gregtyler pushed a commit that referenced this issue Jan 25, 2024
# [2.1.0](v2.0.1...v2.1.0) (2024-01-25)

### Features

* allow Elements to be used components' config ([372d70b](372d70b))
* **navigation:** enhance hover styles of navigation links ([cd0f9df](cd0f9df)), closes [#447](#447)
* **primary-navigation:** auto-hide search toggle when it loses focus ([bedd163](bedd163)), closes [#519](#519)
@gregtyler
Copy link
Contributor Author

🎉 This issue has been resolved in version 2.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility bug A task that fixes something that isn't working released
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants