Update filter 2021 07 16 #230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregtyler
reviewed
Jul 16, 2021
gregtyler
reviewed
Jul 19, 2021
docs/components/filter.md
Outdated
| Using the native date picker as a filter: | ||
|
|
||
| - tested well with users | ||
| - is accessible in all browsers except Firefox |
There was a problem hiding this comment.
Sorry, I wasn't clear with my previous feedback: we didn't find the date picker to be inaccessible with users, they just had usability concerns: you couldn't copy-paste—which you could with our previous JavaScript solution—and entering historic dates was hard, though that UI may have changed now.
I was more meaning to challenge whether it's fair to say it "tested well with users" as a blanket statement, since we also have experience suggesting it didn't in some circumstances.
There was a problem hiding this comment.
Have removed this section.
gregtyler
reviewed
Jul 20, 2021
docs/components/filter.md
Outdated
| - has been usability tested | ||
| - is working in a live service (Sirius for Office of the Public Guardian) | ||
|
|
||
| Users don't always see they can filter. Some users try to filter from the columns headings Sirius for OPG and Manage Offenders in Custody for HMPPS) |
There was a problem hiding this comment.
Looks like a copy-paste artefact?
Suggested change
| Users don't always see they can filter. Some users try to filter from the columns headings Sirius for OPG and Manage Offenders in Custody for HMPPS) | |
| Users don't always see they can filter. Some users try to filter from the columns headings. |
gregtyler
approved these changes
Jul 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #231
Description of the change
Update the 'Filter' component documentation with guidance on:
Release notes
Users will be able to read and follow guidance on when to use the the filter component and it's variations.