-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update filter 2021 07 16 #230
Conversation
docs/components/filter.md
Outdated
Using the native date picker as a filter: | ||
|
||
- tested well with users | ||
- is accessible in all browsers except Firefox |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I wasn't clear with my previous feedback: we didn't find the date picker to be inaccessible with users, they just had usability concerns: you couldn't copy-paste—which you could with our previous JavaScript solution—and entering historic dates was hard, though that UI may have changed now.
I was more meaning to challenge whether it's fair to say it "tested well with users" as a blanket statement, since we also have experience suggesting it didn't in some circumstances.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have removed this section.
docs/components/filter.md
Outdated
- has been usability tested | ||
- is working in a live service (Sirius for Office of the Public Guardian) | ||
|
||
Users don't always see they can filter. Some users try to filter from the columns headings Sirius for OPG and Manage Offenders in Custody for HMPPS) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a copy-paste artefact?
Users don't always see they can filter. Some users try to filter from the columns headings Sirius for OPG and Manage Offenders in Custody for HMPPS) | |
Users don't always see they can filter. Some users try to filter from the columns headings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
Closes #231
Description of the change
Update the 'Filter' component documentation with guidance on:
Release notes
Users will be able to read and follow guidance on when to use the the filter component and it's variations.