MO-1550 Update govuk_notify_rails gem #2471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ticket: https://dsdmoj.atlassian.net/browse/MO-1550 Make code compatible with latest version of the `notifications-ruby-client` (which is a transitive dependency of the `govuk_notify_rails` gem), and was stopping us from updating these dependencies.
zheileman
requested review from
SebNegahbanMoJ
and removed request for
andrewrlee
| gem 'govuk_notify_rails' | ||
| # we need the extra is_csv parameter available in 5.2 and above | ||
| # TODO: update code to work with latest version | ||
| gem 'notifications-ruby-client', '>= 5.2', '< 6.0.0' |
There was a problem hiding this comment.
I assume the removal of this gem is intentional and no-longer needed with the newer notify gem?
There was a problem hiding this comment.
Yes, this gem is a is a transitive dependency of the other gem, thus no need to declare it here. We only had it here temporarily because we needed a specific version until we made the code changes in this PR 👍
SebNegahbanMoJ
approved these changes
Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: https://dsdmoj.atlassian.net/browse/MO-1550
Make code compatible with latest version of the
notifications-ruby-client(which is a transitive dependency of thegovuk_notify_railsgem), and was stopping us from updating these dependencies.