-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MLPAB-307: Donor progress page #292
Conversation
…tions based on Lpa state
// IE8 does not support the text justify approach for spacing | ||
@include govuk-if-ie8 { | ||
display: table; | ||
table-layout: fixed; | ||
width: 100%; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This and other IE8 workarounds are straight from the existing horizontal component CSS and haven't been tested. Thinking maybe to drop them out and this can be revisited if needed when/if we pollinate back to the pattern library?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm fine with us doing a straight copy paste of all this stuff
Codecov ReportBase: 94.22% // Head: 93.88% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #292 +/- ##
==========================================
- Coverage 94.22% 93.88% -0.34%
==========================================
Files 65 66 +1
Lines 3894 4022 +128
==========================================
+ Hits 3669 3776 +107
- Misses 171 192 +21
Partials 54 54
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
// IE8 does not support the text justify approach for spacing | ||
@include govuk-if-ie8 { | ||
display: table; | ||
table-layout: fixed; | ||
width: 100%; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm fine with us doing a straight copy paste of all this stuff
case TaskNotStarted: | ||
return "notStarted" | ||
case TaskInProgress: | ||
return "inProgress" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should probably use "not started" and "in progress" if we are using these for the visually hidden content
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My thinking here was they add context for screen readers given the status is represented as an icon so we'd want to support Welsh for that.
Purpose
Adds a vertical progress bar component based on ministryofjustice/moj-frontend#379 and a progress page so a donor can view the progress of their LPA being registered.
Fixes MLPAB-307
Approach
This ticket ballooned a bit as I started to extend/modify some of the existing features of the app:
Attorney
andReplacementAttorney
Fully aware the
/testing-start
handler is getting a bit ridiculous now but we've had a need for setting app state since sections have become more rigid on being completed. This could form the basis of a fixture feature in the app where we can put a frontend on completing specific or all sections of the donor flow to make demoing and content/design reviews easier.Checklist