-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VEGA-1370 search results page tweaks #237
Conversation
…d. Added styling to filter panel to make it smaller. Removed line breaks
Codecov ReportBase: 73.40% // Head: 73.40% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #237 +/- ##
=======================================
Coverage 73.40% 73.40%
=======================================
Files 83 83
Lines 3012 3012
=======================================
Hits 2211 2211
Misses 576 576
Partials 225 225 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
||
.moj-filter-layout__filter { | ||
width: fit-content; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change is because Katie asked if I could make the filter panel a bit smaller
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems a bit weird to worry about a max of 80px when the page extends the whole screen width but sure 😄
@@ -1,5 +1,5 @@ | |||
{{ define "search-filter" }} | |||
<div class="moj-filter-layout__filter"> | |||
<div class="moj-filter-layout__filter {{ if not .Filters.Set }}govuk-!-display-none{{ end }}"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The behaviour should now be that the filter panel is hidden by default, but shown if filters are selected
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a comment to the moj-frontend discussion so this might be considered in future changes to that component.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice one, thankyou! Hopefully so yeah :)
No description provided.