Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[do not merge] PIC-2389: Update PACT tests for case comments feature #932

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Obsiye
Copy link
Contributor

@Obsiye Obsiye commented Apr 11, 2024

Update the Pact tests for case comments

  • Update the endpoints for creating a case comment in the pact tests

This is because court case service and this service uses the endpoint /cases/:id/defendants/:id/comments
rather than /cases/:id/comments

This change should fix the PACT tests

Additional information:
This works on top of the previous PR
#658

TO DO:

  • Uncomment out pact_push from CI/CD
  • Fix broken PACT tests or migrate to something else

Update the Pact tests for case comments by updating the endpoints
for creating a case comment.

This is because court case service uses the endpoint
.../cases/:id/defendants/:id/comments
rather than
.../cases/:id/comments

This change should fix the PACT tests
@Obsiye Obsiye marked this pull request as ready for review April 11, 2024 11:03
@Obsiye Obsiye changed the title PIC-2389: Update PACT tests for case comments feature [do not merge] PIC-2389: Update PACT tests for case comments feature Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant