Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add automatic soft isolation to Session docs #52

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions guides/session.rst
Original file line number Diff line number Diff line change
Expand Up @@ -183,10 +183,16 @@ Resetting the Session
---------------------

The primary aim for Mink is to provide a single consistent web browsing API
for acceptance tests. But a very important part in testing is isolation.

Mink provides two very useful methods to isolate tests, which can be used
in your test's ``teardown`` methods:
for acceptance tests. But a very important part in testing is isolation.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't add trailing whitespaces

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better yet enable automatic trailing space removal in your editor.

Mink tries to automatically "soft" isolate Scenarios from each other without
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this documentation should not talk about scenarios. Scenarios are a Behat concept, not a Mink one. Mink is not tied to Behat

slowing-down test runs with a full driver restart, but in some cases this is not
possible:
* Selenium will not allow cookies to be cleared from anything other than
the current domain - so a scenario that runs across different domains (for
example PayPal's sandbox) cannot be automatically isolated.

So Mink provides two very useful methods to isolate tests, which can be used
in your tests' ``teardown`` methods:

.. code-block:: php

Expand Down