-
-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nested Destructuring #593
Merged
Merged
Nested Destructuring #593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This implements a recursive algorithm for destructuring and unifies statement and case branch checks.
Compiler is made to compile the tests but needs rewriting.
gdotdesign
commented
May 5, 2023
Sija
reviewed
May 5, 2023
@gdotdesign Does it resolves #283? |
Yes it will :) |
Sija
reviewed
May 8, 2023
Co-authored-by: Sijawusz Pur Rahnama <sija@sija.pl>
Sija
reviewed
May 9, 2023
Sija
approved these changes
May 9, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✨
Sija
reviewed
May 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements a recursive algorithm for destructuring and unifies statement and case branch destructuring checks. This allows:
if
expressionsSome examples:
Top level exhaustiveness checking is still there but if any branch has nested destructuring or value (
"string"
for example) in it then it's excluded from the check.Follow-up work (in separate PRs):
_match
and related functions into the runtime