-
-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Localization Language Feature #618
Conversation
Co-authored-by: jansul <jon@sul.ly>
A couple of localization thoughts just from experience with it in our prod app:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the approach of making the translations a first class citizen. I believe though that the implementation should handle the pluralization, loading data from files and the other points raised by @farism.
I agree on all parts, but it needs to be a multi-stage process, we can't implement everything in one PR.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would generally agree with @gdotdesign, there doesn't seem to be anything about this design that would prevent implementing most of the features mentioned.
The only awkward thing might be:
2. When using a localization service (Phrase, Smartling, and other services like this) they generally expect to be working with some standardized data exchange format like
.yaml
or.json
. Something to think about from a workflow perspective.
However I don't think it's worth giving up the flexibility of the values being expressions to support these services. Hopefully we could find a nice way of importing/exporting locales in a way that works with them.
Co-authored-by: jansul <jon@sul.ly>
This PR adds language features for handling localizations: https://github.com/mint-lang/mint/blob/locales/documentation/Language/Locale.md