Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propagate SIGTERM for graceful shutdown #110

Merged
merged 1 commit into from
Oct 23, 2019
Merged

Commits on Oct 22, 2019

  1. Propagate SIGTERM for graceful shutdown

    If the process receiving the signal is PID 1, it gets special treatment
    by the kernel; if it hasn't registered a handler for the signal, the
    kernel won't fall back to default behavior, and nothing happens. Prior
    to this patch, the entrypoint script is PID 1 in the container, and by
    default, shell does not register SIGTERM handler. As a result, `docker
    stop` will not work properly when trying to gracefully shutdown the
    container.
    
    This patch adds `tini` to be the PID 1 in the container to do PID 1
    things, and correctly propagate the SIGTERM signal.
    jieyu committed Oct 22, 2019
    Configuration menu
    Copy the full SHA
    d1d2d59 View commit details
    Browse the repository at this point in the history