Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: bad indentation in deployment template #137

Merged
merged 1 commit into from
Jul 6, 2020
Merged

fix: bad indentation in deployment template #137

merged 1 commit into from
Jul 6, 2020

Conversation

kormotodor
Copy link
Contributor

for nodeSelector & tolerations fields

@kormotodor
fix: bad indentation in deployment template
507223f 
for nodeSelector & tolerations fields
@nabadger
Copy link
Contributor

nabadger commented Jun 25, 2020 •
edited
Loading

@primeroz I'll check the commit history for this as I recall similar fixes in the past.

I suspect the CI checks are not picking this up, as node-selectors/toleration are not set (they probably should be...).

@nabadger
Copy link
Contributor

nabadger commented Jun 25, 2020 •
edited
Loading

@primeroz I'll check the commit history for this as I recall similar fixes in the past.

I suspect the CI checks are not picking this up, as node-selectors/toleration are not set (they probably should be...).

Ok it was only the affinity rule that was fixed.

53ba4c8#diff-4f48a82f8a6013d7aa9c016dd6e9ac1f

@nabadger nabadger merged commit 92ed659 into mintel:master Jul 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nabadger nabadger nabadger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kormotodor @nabadger