Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it possible to encode to addresses when encoding blocks or transactions to json #1200

Closed
TheQuantumPhysicist opened this issue Sep 18, 2023 · 0 comments · Fixed by #1238
Labels
chainstate Chainstate-related issues good first issue Good for newcomers rpc Everything related to RPC serialization Everything related to serialization, whether bytes, hex, json or otherwise

Comments

@TheQuantumPhysicist
Copy link
Contributor

In #1155, we serialize using serde_json. However, while we can serialize destinations and ids to hex, some of these elements are better serialized to a proper readable address. The problem is that the serialization of these elements depends on chain config, and serde_json doesn’t seem to have a way to accept a state, such as chain config.
We would like to avoid having to use a global variable that stores chain config for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chainstate Chainstate-related issues good first issue Good for newcomers rpc Everything related to RPC serialization Everything related to serialization, whether bytes, hex, json or otherwise
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant