Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RPC json elements now can return proper addresses instead of hex values #1238

Merged
merged 7 commits into from
Oct 2, 2023
Merged

RPC json elements now can return proper addresses instead of hex values #1238

merged 7 commits into from
Oct 2, 2023

Conversation

TheQuantumPhysicist
Copy link
Collaborator

@TheQuantumPhysicist TheQuantumPhysicist commented Sep 27, 2023 •
edited

So, given that serde::Serialize has no state, this is the only way I could do this. Let me know what you think.

Closes #1200

@TheQuantumPhysicist TheQuantumPhysicist marked this pull request as draft September 28, 2023 11:25
@TheQuantumPhysicist TheQuantumPhysicist marked this pull request as ready for review September 28, 2023 12:39
OBorce
OBorce approved these changes Sep 29, 2023
View reviewed changes
Copy link
Contributor

@OBorce OBorce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK

@TheQuantumPhysicist TheQuantumPhysicist merged commit ef59b6b into master Oct 2, 2023
23 checks passed
@TheQuantumPhysicist TheQuantumPhysicist deleted the fix/json_encoding_addresses branch October 2, 2023 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@muursh muursh muursh approved these changes

@OBorce OBorce OBorce approved these changes

@erubboli erubboli Awaiting requested review from erubboli erubboli is a code owner

@iljakuklic iljakuklic Awaiting requested review from iljakuklic

@azarovh azarovh Awaiting requested review from azarovh azarovh is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make it possible to encode to addresses when encoding blocks or transactions to json
3 participants
@TheQuantumPhysicist @muursh @OBorce