Don't stake for previously staked times #1083
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alfiedotwtf
requested review from
muursh,
erubboli,
iljakuklic,
TheQuantumPhysicist and
azarovh
as code owners
TheQuantumPhysicist
approved these changes
Jul 27, 2023
iljakuklic
reviewed
Jul 31, 2023
iljakuklic
approved these changes
Jul 31, 2023
alfiedotwtf
force-pushed
the
alfie/skip-timestamps
branch
from
4e74f2e
to
9b11507
Compare
muursh
approved these changes
Aug 1, 2023
azarovh
approved these changes
Aug 1, 2023
blockprod/src/detail/mod.rs
Outdated
| pub fn generate_custom_id(&self, input_data: &GenerateBlockInputData) -> CustomId { | ||
| match input_data { | ||
| GenerateBlockInputData::PoS(pos_input_data) => { | ||
| pos_input_data.stake_public_key().encode() |
There was a problem hiding this comment.
not sure how important that is but it's confusing that PoS returns the same value every time. Given that struct is called "generate" and for PoW it actually generates random value. Is it intended?
There was a problem hiding this comment.
Yeah. So the function "generates" for PoW, but for PoS the value is fixed. The struct has a "Generate" prefix because it's the struct for the "generate_block()" RPC call.
TheQuantumPhysicist
approved these changes
Aug 2, 2023
azarovh
approved these changes
Aug 3, 2023
iljakuklic
approved these changes
Aug 3, 2023
alfiedotwtf
force-pushed
the
alfie/skip-timestamps
branch
from
cf5f769
to
0a9a5c8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #1005 for more details.