Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix transaction broadcasting in wallet commands to be consistent #1125

Conversation

OBorce
Copy link
Contributor

@OBorce OBorce commented Aug 2, 2023

Reuse the broadcasting functionality in all commands to be the same

Copy link
Collaborator

@TheQuantumPhysicist TheQuantumPhysicist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm OK with this... but we should start writing tests to ensure these contracts are handled properly.

@TheQuantumPhysicist TheQuantumPhysicist merged commit 11b34d6 into master Aug 3, 2023
23 checks passed
@TheQuantumPhysicist TheQuantumPhysicist deleted the fix/consistent-tx-broadcasting-of-wallet-commands branch August 3, 2023 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants