Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set RUST_BACKTRACE by default #1143

Merged
merged 1 commit into from
Aug 7, 2023
Merged

Conversation

pavel-kokolemin
Copy link
Contributor

@pavel-kokolemin pavel-kokolemin commented Aug 7, 2023

I think it will be a little easier for everyone if we set RUST_BACKTRACE by default for our executables.
This can be useful for regular GUI users (but only if we also use file logging and log crashes).

Copy link
Contributor

@ImplOfAnImpl ImplOfAnImpl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO the "rust_" part of the module name is redundant, I'd remove it.

@TheQuantumPhysicist
Copy link
Collaborator

IMO the "rust_" part of the module name is redundant, I'd remove it.

It's helpful to keep it to recognize that this is something that's language specific, and not application specific.

@pavel-kokolemin pavel-kokolemin merged commit 1375c9e into master Aug 7, 2023
23 checks passed
@pavel-kokolemin pavel-kokolemin deleted the enable_rust_backtrace branch August 7, 2023 09:52
@ImplOfAnImpl
Copy link
Contributor

IMO the "rust_" part of the module name is redundant, I'd remove it.

It's helpful to keep it to recognize that this is something that's language specific, and not application specific.

Well, by this logic we'll probably have to use this prefix for anything that is a wrapper for standard library stuff, which sounds like an overkill.

@TheQuantumPhysicist
Copy link
Collaborator

Well, by this logic we'll probably have to use this prefix for anything that is a wrapper for standard library stuff, which sounds like an overkill.

Not really. I understand why you think like that, but when looking at utils, it's then obvious that this is something different. It's not really a wrapper, it's a configuration of the compiler.

This is my opinion, and quite frankly doesn't matter that much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants