Chainstate special RPC types #1161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheQuantumPhysicist
requested review from
muursh,
erubboli,
iljakuklic and
azarovh
as code owners
iljakuklic
approved these changes
Aug 10, 2023
Comment on lines
+22
to
+24
| pub struct RpcSignedTransaction { | ||
| id: Id<Transaction>, | ||
| tx: SignedTransaction, |
There was a problem hiding this comment.
Should both transaction Id and the serialized hash (including witness) be included?
There was a problem hiding this comment.
This is just a start... we can add more later when we need them.
Comment on lines
+30
to
+34
| pub fn new(block: Block, block_index: BlockIndex) -> Self { | ||
| Self { | ||
| id: block.get_id(), | ||
| height: block_index.block_height(), | ||
| block, |
There was a problem hiding this comment.
Thereare some other fields in BlockIndex that we may consider including, namely chain_trust and status.
There was a problem hiding this comment.
Agreed, but again, we can do that later. I just did this as a proof of concept so that people don't become too inventive to solve this problem :D
azarovh
approved these changes
Aug 10, 2023
muursh
reviewed
Aug 10, 2023
chainstate/src/rpc/types/block.rs
Outdated
| @@ -0,0 +1,37 @@ | |||
| // Copyright (c) 2022 RBB S.r.l | |||
There was a problem hiding this comment.
Come and join us in the future my man
There was a problem hiding this comment.
Nah... I like it here better. Now leave me alone 😄
muursh
approved these changes
Aug 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These types are used to add more information to the output of json RPC instead of just serializing the raw data from that type.