Small code deduplication between peer v1 and v2. Singular unconnected headers are now disallowed in v2. #1184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ImplOfAnImpl
requested review from
muursh,
erubboli,
iljakuklic,
TheQuantumPhysicist and
azarovh
as code owners
Base automatically changed from
p2p_handle_bad_handshake_and_version
to
p2p_protocol_v2
September 14, 2023 14:15
…cache the is_initial_block_download value and get rid of the corresponding atomics; choose_peers_best_block was moved to peer_common; handle_result was renamed.
… place where it could be used in the future
ImplOfAnImpl
force-pushed
the
p2p_peer_code_dedup
branch
from
f44b702
to
2805e54
Compare
TheQuantumPhysicist
approved these changes
Sep 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This supersedes https://git.mintlayer.org/mintlayer/mintlayer-core/-/merge_requests/1150