Replace API Server's mock data responses with database calls #1190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheQuantumPhysicist
approved these changes
Sep 15, 2023
alfiedotwtf
requested review from
muursh,
erubboli,
iljakuklic and
azarovh
as code owners
iljakuklic
approved these changes
Sep 15, 2023
Comment on lines
+95
to
+102
| state | ||
| .db | ||
| .transaction_ro() | ||
| .map_err(|_| { | ||
| APIServerWebServerError::ServerError( | ||
| APIServerWebServerServerError::InternalServerError, | ||
| ) | ||
| })? |
There was a problem hiding this comment.
Could you define a constant or something for the error? I don't like how a mere conversion of error type takes up 5 lines while the actual "substantive" code is a fraction of that.
There was a problem hiding this comment.
This is replicated many times over.
There was a problem hiding this comment.
Yep. There's currently not that many error types, but once it's fully fleshed out, I'll replace the errors with real constants.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of the current API server endpoints are now pulling from a database handle.