Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Followup for the "use tracing" PR #1191

Merged
merged 2 commits into from
Sep 21, 2023
Merged

Followup for the "use tracing" PR #1191

merged 2 commits into from
Sep 21, 2023

Conversation

ImplOfAnImpl
Copy link
Contributor

Here is a bunch of trivial changes that were originally in #1187:

  1. The removal of the unused parameter in init_logging.
  2. Adding #[tracing::instrument] calls to all tests in p2p;

The global initialization of logging in p2p tests via ctor is also here.

@ImplOfAnImpl ImplOfAnImpl mentioned this pull request Sep 15, 2023
Merged
@ImplOfAnImpl ImplOfAnImpl marked this pull request as ready for review September 15, 2023 16:50
Base automatically changed from use_tracing to master September 21, 2023 11:50
@TheQuantumPhysicist TheQuantumPhysicist merged commit e907782 into master Sep 21, 2023
12 checks passed
@TheQuantumPhysicist TheQuantumPhysicist deleted the use_tracing_followup branch September 21, 2023 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iljakuklic iljakuklic iljakuklic approved these changes

@muursh muursh muursh approved these changes

@TheQuantumPhysicist TheQuantumPhysicist TheQuantumPhysicist approved these changes

@erubboli erubboli Awaiting requested review from erubboli erubboli is a code owner

@azarovh azarovh Awaiting requested review from azarovh azarovh is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ImplOfAnImpl @iljakuklic @muursh @TheQuantumPhysicist