Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix delegation support in the wallet #1225

Merged
merged 1 commit into from
Sep 20, 2023
Merged

Fix delegation support in the wallet #1225

merged 1 commit into from
Sep 20, 2023

Conversation

OBorce
Copy link
Contributor

@OBorce OBorce commented Sep 20, 2023

  • previously all delegation staking was added as own in the cache
  • fix delegation rollback when a reorg happens
  • fix delegation nonce rollback when abandoning inactive transactions with descendants

TheQuantumPhysicist
TheQuantumPhysicist approved these changes Sep 20, 2023
View reviewed changes
Copy link
Collaborator

@TheQuantumPhysicist TheQuantumPhysicist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we please add some functional tests? Besides this, this is OK.

muursh
muursh reviewed Sep 20, 2023
View reviewed changes
wallet/src/account/mod.rs Outdated Show resolved Hide resolved
@OBorce OBorce force-pushed the fix/refactor-wallet-delegations branch from ba89496 to 3cf71fd Compare September 20, 2023 14:45
@OBorce
Fix delegation support in the wallet
7097528 
- previously all delegation staking was added as own in the cache
- fix delegation rollback when a reorg happens
- fix delegation nonce rollback when abandoning inactive transactions
  with descendants
@OBorce OBorce force-pushed the fix/refactor-wallet-delegations branch from 3cf71fd to 7097528 Compare September 20, 2023 15:23
@OBorce OBorce merged commit 97108b0 into master Sep 20, 2023
23 checks passed
@OBorce OBorce deleted the fix/refactor-wallet-delegations branch September 20, 2023 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@muursh muursh muursh approved these changes

@TheQuantumPhysicist TheQuantumPhysicist TheQuantumPhysicist approved these changes

@erubboli erubboli Awaiting requested review from erubboli erubboli is a code owner

@iljakuklic iljakuklic Awaiting requested review from iljakuklic

@azarovh azarovh Awaiting requested review from azarovh azarovh is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@OBorce @muursh @TheQuantumPhysicist