Reduce log level of certain logging lines from "debug" to "trace" to reduce test logs bloat #1227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…reduce test logs bloat
ImplOfAnImpl
requested review from
muursh,
erubboli,
iljakuklic,
TheQuantumPhysicist and
azarovh
as code owners
iljakuklic
approved these changes
Sep 20, 2023
TheQuantumPhysicist
approved these changes
Sep 21, 2023
muursh
approved these changes
Sep 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initially I was going to reduce the number of blocks generated by tests to fix this, but now I think it would be a bad idea. So, in the end I've just demoted the most spamming logging lines from "debug" to "trace".
(Just in case: the main offenders here are the lines in mempool, the other ones are just accomplices).
I also described the issue in detail here - #1219 (comment)