Use podman to run postgres tests #1229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheQuantumPhysicist
requested review from
muursh,
erubboli,
iljakuklic and
azarovh
as code owners
Base automatically changed from
fix/postgres-async-with-tx-dropper
to
fix/postgres
September 21, 2023 23:29
|
This is ready for review. The only thing left is to add a feature that will force enabling the containerized test, which I'll do tomorrow because it's too late. |
alfiedotwtf
approved these changes
Sep 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I created my own facility to run podman since testcontainers-rs is ugly with its unjustified lifetime and lacks direct support for podman.
At the time of creating this PR, I'm able to launch containers and stop them automatically, but I still need to configure the container properly to get the tests to work.