Add CLI option to control feerate argument from mempool #1230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OBorce
requested review from
muursh,
erubboli,
iljakuklic,
TheQuantumPhysicist and
azarovh
as code owners
TheQuantumPhysicist
changed the title
node-gui/src/backend/backend_impl.rs
Outdated
| @@ -376,7 +376,8 @@ impl Backend { | |||
| .get_mut(&wallet_id) | |||
| .ok_or(BackendError::UnknownWalletIndex(wallet_id))? | |||
| .controller | |||
| .synced_controller(account_index) | |||
| // TODO: add option to select from GUI | |||
| .synced_controller(account_index, ControllerConfig { in_top_x_mb: 5 }) | |||
There was a problem hiding this comment.
Please, no magic numbers in the middle of the code.
There was a problem hiding this comment.
added the constant at the top with a comment
test-rpc-functions/src/rpc.rs
Outdated
Comment on lines
294
to
295
| .expect("Subsystem call ok") | ||
| .expect("Subsystem call ok"); |
There was a problem hiding this comment.
It's a very bad idea to have two expects, right after each other, and with the exact same message... basically if this error happens, it may be difficult to know where it really happened.
TheQuantumPhysicist
approved these changes
Sep 22, 2023
- add in-top-x-mb argument to control how much to prioritize the transaction feerate so the transaction can get in the top x MB of the mempool - add functional test
OBorce
force-pushed
the
feature/high-feerate-functional-test
branch
from
e1804c0
to
40709c0
Compare
TheQuantumPhysicist
deleted the
feature/high-feerate-functional-test
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
transaction feerate so the transaction can get in the top x MB of the
mempool