Some code deduplication related to peer db storage #1231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ImplOfAnImpl
requested review from
muursh,
erubboli,
iljakuklic,
TheQuantumPhysicist and
azarovh
as code owners
|
Besides the macros, I'm OK with this PR. |
ImplOfAnImpl
force-pushed
the
peer_db_code_dedup
branch
from
2f8318b
to
0458a5d
Compare
TheQuantumPhysicist
approved these changes
Sep 22, 2023
iljakuklic
approved these changes
Sep 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the duplication of the function
update_dband traits "XxxTransactionRo", "XxxTransactionRw" and "XxxTransactional" betweendns_server/src/crawler_p2p/crawler_manager/storage...andp2p/src/peer_manager/peerdb/storage...