Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update iced gui library 0.9 -> 0.10 #1232

Merged
merged 5 commits into from
Sep 28, 2023
Merged

Conversation

OBorce
Copy link
Contributor

@OBorce OBorce commented Sep 22, 2023

Update the iced library because of a security issue related to its dependency ouroboros.

New:

  • Show an info message when trying to mutate the wallet while still syncing.
  • Use different channels for wallet update events to avoid flooding the channel while scanning many blocks when multiple wallets opened, and cause lagging in processing the user commands.

@TheQuantumPhysicist
Copy link
Collaborator

There are a few things broken in the wallet. When creating a new wallet, the wallet just keeps getting created indefinitely. Also the progress bar for wallet syncing is not showing up.

Please run every functionality in the old wallet and the new wallet side by side and ensure that everything behaves correctly. In fact, it's an open question how we test these features.

@TheQuantumPhysicist
Copy link
Collaborator

I made an attempt to fix the issue Lukas pointed to. It's not perfect given that the number of wallets is dynamic, but perhaps this is good for what it's. Feel free to improve it.

@OBorce OBorce marked this pull request as draft September 24, 2023 10:24
@OBorce OBorce marked this pull request as ready for review September 26, 2023 13:12
@OBorce OBorce marked this pull request as draft September 27, 2023 09:39
- avoid filling up the responses channel from user commands with wallet
  updates when scanning new blocks
@OBorce OBorce marked this pull request as ready for review September 27, 2023 23:57
@OBorce OBorce merged commit 0914b77 into master Sep 28, 2023
23 checks passed
@OBorce OBorce deleted the fix/update-iced-dependency branch September 28, 2023 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants