Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use only checked math ops for Uint* types #1243

Merged
merged 6 commits into from
Sep 29, 2023
Merged

Use only checked math ops for Uint* types #1243

merged 6 commits into from
Sep 29, 2023

Conversation

TheQuantumPhysicist
Copy link
Collaborator

Closes #1218

iljakuklic
iljakuklic approved these changes Sep 29, 2023
View reviewed changes
Copy link
Contributor

@iljakuklic iljakuklic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

common/src/chain/block/consensus_data.rs Outdated Show resolved Hide resolved
consensus/src/pow/helpers.rs Show resolved Hide resolved
@TheQuantumPhysicist TheQuantumPhysicist merged commit e3c8196 into master Sep 29, 2023
23 checks passed
@TheQuantumPhysicist TheQuantumPhysicist deleted the fix/checked_ops_uint branch September 29, 2023 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iljakuklic iljakuklic iljakuklic approved these changes

@azarovh azarovh azarovh approved these changes

@muursh muursh Awaiting requested review from muursh

@erubboli erubboli Awaiting requested review from erubboli erubboli is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use checked functions for all uint operations
3 participants
@TheQuantumPhysicist @iljakuklic @azarovh