Use ConnectivityEvent::Misbehaved to report unexpected handshakes #1245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ImplOfAnImpl
requested review from
muursh,
erubboli,
iljakuklic,
TheQuantumPhysicist and
azarovh
as code owners
ImplOfAnImpl
force-pushed
the
p2p_crawler_peers_ban
branch
from
6443562
to
fbe581c
Compare
ImplOfAnImpl
force-pushed
the
misbehaved_on_unexpected_handshake
branch
from
d96dc62
to
afbfd6e
Compare
TheQuantumPhysicist
approved these changes
Oct 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This applies a TODO about
ConnectivityEvent::Misbehavedbeing unused and unexpected Handshake messages not being reported to PeerManager.I also had to address the issue with spurious failures of tests in p2p/src/tests due to a test exiting too early. To fix this I introduced the test "Observer" for PeerManager, so that tests can now wait for a notification to occur and only then start checking for expected conditions.