Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix next_connect_time #1249

Merged
merged 2 commits into from
Oct 2, 2023
Merged

Fix next_connect_time #1249

merged 2 commits into from
Oct 2, 2023

Conversation

ImplOfAnImpl
Copy link
Contributor

  1. exponential_rand can no longer produce infinity.
  2. next_connect_time now clamps the generated factor to a reasonable value (because the result of exponential_rand can still be quite big for a factor)

This fixes #1239

@TheQuantumPhysicist TheQuantumPhysicist merged commit fb69030 into master Oct 2, 2023
23 checks passed
@TheQuantumPhysicist TheQuantumPhysicist deleted the fix_next_connect_time branch October 2, 2023 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheQuantumPhysicist TheQuantumPhysicist TheQuantumPhysicist approved these changes

@muursh muursh Awaiting requested review from muursh

@erubboli erubboli Awaiting requested review from erubboli erubboli is a code owner

@iljakuklic iljakuklic Awaiting requested review from iljakuklic

@azarovh azarovh Awaiting requested review from azarovh azarovh is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

next_connect_time() uses a relatively complicated way to ensure the sanity of the PDF used
2 participants
@ImplOfAnImpl @TheQuantumPhysicist