Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce PoSChainConfigBuilder and change maturity distances for Testnet #1250

Merged
merged 3 commits into from
Oct 5, 2023

Conversation

azarovh
Copy link
Member

@azarovh azarovh commented Sep 30, 2023

The main goal for this PR is to change maturity distances for Testnet from 2000 to 7200 for both decommissioning and spending a share.
But the way PoSChainConfig had been initialising was inconvenient so I added PoSChainConfigBuilder.

Copy link
Collaborator

@TheQuantumPhysicist TheQuantumPhysicist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As agreed, the builder should go to unit tests only to simplify, and there should not be defaults that specify complex consensus rules.

@azarovh azarovh marked this pull request as draft October 4, 2023 09:13
@azarovh azarovh force-pushed the feat/pos_chain_config_builder branch from 9422a58 to 739cb08 Compare October 4, 2023 09:20
@azarovh azarovh marked this pull request as ready for review October 4, 2023 09:22
@azarovh azarovh merged commit b1aecbb into master Oct 5, 2023
23 checks passed
@azarovh azarovh deleted the feat/pos_chain_config_builder branch October 5, 2023 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants