Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

subsystem: Remove custom event loop support #1256

Merged
merged 3 commits into from
Oct 5, 2023
Merged

subsystem: Remove custom event loop support #1256

merged 3 commits into from
Oct 5, 2023

Conversation

iljakuklic
Copy link
Contributor

  • Generalized the built-in event loop with
    • Custom initialization
    • Separation between subsystem state object and interface
    • Ability to specify background work in the Subsystem trait
  • Ported p2p to the built-in event loop
  • Ported tests to the built-in event loop
  • Removed support for custom event loop from subsystem
  • Substantial subsystem crate code reorganization

Related:

@iljakuklic iljakuklic added this to the Mainnet milestone Oct 3, 2023
@iljakuklic iljakuklic linked an issue Oct 3, 2023 that may be closed by this pull request
Take advantage of the separation between mutable and immutable subsystem calls #131
Closed
TheQuantumPhysicist
TheQuantumPhysicist approved these changes Oct 4, 2023
View reviewed changes
Copy link
Collaborator

@TheQuantumPhysicist TheQuantumPhysicist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. Great work!

muursh
muursh approved these changes Oct 4, 2023
View reviewed changes
Copy link
Contributor

@muursh muursh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm alright with this

@iljakuklic iljakuklic force-pushed the subsystem-init branch 8 times, most recently from b192d69 to 81549e8 Compare October 4, 2023 20:54
@iljakuklic
subsystem: Remove custom event loop support
6b6a1c1 
* Generalized the built-in event loop with
  * Custom initialization
  * Separation between subsystem state object and interface
  * Ability to specify background work in the `Subsystem` trait
* Ported `p2p` to the built-in event loop
* Ported tests to the built-in event loop
* Removed support for custom event loop from subsystem
* Substantial `subsystem` crate code reorganization
@iljakuklic
subsystem: Fix typos
ca9f322
@iljakuklic
subsystem: Make signal handlers futures
148fce5 
Change signal handlers (Ctrl-C / SIGTERM) to be plain futures rather
than something that runs on a separate task. Yields simpler code.
@iljakuklic iljakuklic merged commit 23d426d into master Oct 5, 2023
23 checks passed
@iljakuklic iljakuklic deleted the subsystem-init branch October 5, 2023 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alfiedotwtf alfiedotwtf alfiedotwtf approved these changes

@muursh muursh muursh approved these changes

@TheQuantumPhysicist TheQuantumPhysicist TheQuantumPhysicist approved these changes

@OBorce OBorce Awaiting requested review from OBorce

@azarovh azarovh Awaiting requested review from azarovh azarovh is a code owner

@erubboli erubboli Awaiting requested review from erubboli erubboli is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Mainnet
Development

Successfully merging this pull request may close these issues.

Take advantage of the separation between mutable and immutable subsystem calls
4 participants
@iljakuklic @alfiedotwtf @muursh @TheQuantumPhysicist