Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reset the keychain in-memory state on tx error #1257

Merged
merged 1 commit into from
Oct 4, 2023
Merged

Reset the keychain in-memory state on tx error #1257

merged 1 commit into from
Oct 4, 2023

Conversation

OBorce
Copy link
Contributor

@OBorce OBorce commented Oct 3, 2023 •
edited

  • in case of an error while creating a transaction any keys generated in memory will be reset by reloading the state from the DB

closes #1173

@OBorce
Reset the keychain in-memory state on tx error
0e032e5 
- in case of an error while creating a transaction any keys generated in
  memory will be reset by reloading the state from the DB
@TheQuantumPhysicist TheQuantumPhysicist merged commit 8c713f6 into master Oct 4, 2023
23 checks passed
@TheQuantumPhysicist TheQuantumPhysicist deleted the fix/wallet-key-consumption-failed-tx branch October 4, 2023 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@muursh muursh muursh approved these changes

@TheQuantumPhysicist TheQuantumPhysicist TheQuantumPhysicist approved these changes

@erubboli erubboli Awaiting requested review from erubboli erubboli is a code owner

@iljakuklic iljakuklic Awaiting requested review from iljakuklic

@azarovh azarovh Awaiting requested review from azarovh azarovh is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Keys are consumed even if createstakepool transaction creation fails
3 participants
@OBorce @muursh @TheQuantumPhysicist