Add wallet address generator binary #1261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
OBorce
commented
Oct 5, 2023
OBorce
commented
- used for generating new seed phrase and addresses for mainnet
- used for generating new seed phrase and addresses for mainnet
OBorce
requested review from
muursh,
erubboli,
iljakuklic,
TheQuantumPhysicist and
azarovh
as code owners
|
|
||
| pub fn run(args: CliArgs) -> Result<(), CliError> { | ||
| ensure!( | ||
| args.number_addresses <= 20, |
There was a problem hiding this comment.
This number should come from the default gap in the wallet, I'd say. Is it possible to do that?
There was a problem hiding this comment.
Fixed used the LOOKAHEAD_SIZE constant from the keychain
…/mintlayer/mintlayer-core into feature/wallet-address-generator
TheQuantumPhysicist
approved these changes
Oct 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.