Minor: Add documentation to generate_block to warn against misusing parameters #1277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheQuantumPhysicist
requested review from
muursh,
erubboli,
iljakuklic and
azarovh
as code owners
alfiedotwtf
reviewed
Oct 17, 2023
alfiedotwtf
reviewed
Oct 17, 2023
| /// If the transactions are not valid, the block will be rejected and will not be included in the blockchain. | ||
| /// It's preferable to use `transaction_ids` instead, where the mempool will ensure that the transactions are valid | ||
| /// against the current state of the blockchain. | ||
| /// - `transaction_ids`: The transaction IDs of the transactions to be included in the block from the mempool. |
alfiedotwtf
approved these changes
Oct 17, 2023
iljakuklic
approved these changes
Oct 17, 2023
muursh
approved these changes
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.